Fix NEW targets getting distance -1 when max_distance is set#99
Merged
Conversation
computeDistances() was resetting all non-DIRECT targets to -1, overwriting the distance 0 that getDefaultDistance correctly assigned to NEW targets. The BFS only seeded DIRECT targets, so NEW targets stayed at -1 and were dropped by filterChangedTargetsByDistance. Treat CHANGE_TYPE_NEW the same as CHANGE_TYPE_DIRECT in the BFS initialization: seed them at distance 0 so they survive distance filtering and propagate through reverse deps.
|
|
yushan8
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeDistances() was resetting all non-DIRECT targets to -1, overwriting the distance 0 that getDefaultDistance correctly assigned to NEW targets. The BFS only seeded DIRECT targets, so NEW targets stayed at -1 and were dropped by filterChangedTargetsByDistance.
Treat CHANGE_TYPE_NEW the same as CHANGE_TYPE_DIRECT in the BFS initialization: seed them at distance 0 so they survive distance filtering and propagate through reverse deps.
Test Plan
unit test
Issue