Skip to content

Expose retryOn configuration in tchannel client#892

Open
mahipjain wants to merge 7 commits intouber:masterfrom
mahipjain:retryon
Open

Expose retryOn configuration in tchannel client#892
mahipjain wants to merge 7 commits intouber:masterfrom
mahipjain:retryon

Conversation

@mahipjain
Copy link
Member

@mahipjain mahipjain commented Jul 12, 2023

Currently, there is no way to configure what types of errors the client should retry on, so we always fall back to the default behavior of RetryConnectionError. Exposing this configuration as part of TChannelClientOption

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jul 12, 2023

Coverage Status

coverage: 68.859% (-0.4%) from 69.252% when pulling a8e3a0c on mahipjain:retryon into 8c037de on uber:master.

@mahipjain mahipjain marked this pull request as ready for review July 12, 2023 23:05
@mahipjain mahipjain marked this pull request as draft July 12, 2023 23:13
@mahipjain mahipjain marked this pull request as ready for review July 17, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants