This repository was archived by the owner on Nov 4, 2023. It is now read-only.
[Indicators] Add support for ayatana indicators#326
Draft
Conversation
This adds support for ayatana indicators but keeps the existing unity indicators to support legacy indicators, this also cleans up the indicator load logic.
peat-psuwit
reviewed
Aug 12, 2020
Contributor
peat-psuwit
left a comment
peat-psuwit
left a comment
There was a problem hiding this comment.
LGTM, but someone else must approve. Didn't test or anything.
As this merges to xenial branch, maybe wait for OTA-13 to be released first?
Member
Author
|
@UniversalSuperBox what do you think? |
dobey
suggested changes
Oct 9, 2020
Member
dobey
left a comment
dobey
left a comment
There was a problem hiding this comment.
Needs to update/add tests and data for these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for ayatana indicators but keeps the existing unity indicators to support legacy indicators, this also cleans up the indicator load logic.
This opts to add each indicator menu types to the qml object instead of doing a hacky replace string logic, this way we save cpu cycles but at a ultra minor memory bump.