This repository was archived by the owner on Nov 4, 2023. It is now read-only.
Disable shortcuts when launcher is not available#379
Open
kugiigi wants to merge 2 commits intoubports:xenialfrom
Open
Disable shortcuts when launcher is not available#379kugiigi wants to merge 2 commits intoubports:xenialfrom
kugiigi wants to merge 2 commits intoubports:xenialfrom
Conversation
This will disable launcher shortcuts when launcher is disabled or not available i.e. Launcher is disabled in lock screen.
Member
|
This PR looks good to me, but I believe a unit test should be added to ensure that the shortcuts do not function when the shell is locked. This will ensure that we don't add this bug back in the future. |
dobey
suggested changes
May 13, 2021
Member
dobey
left a comment
dobey
left a comment
There was a problem hiding this comment.
Please add a test to ensure this doesn't break in the future, as Dalton requested.
Also, it might be good to clean up the commits by squashing with git rebase -i after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables keyboard shortcuts when the launcher is disabled or not available.
i.e. Launcher is disabled in lock screen.
Currently, swiping won't show the launcher if it's disabled in lock screen but keyboard shortcuts are still working.