Skip to content

Quote mirror script path expansions in mirror docs #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utkarsh2102 merged 2 commits into from
Jul 9, 2026
Merged

Quote mirror script path expansions in mirror docs #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f788b73
Initial plan
Copilot Jul 8, 2026
b3caa33
Quote mirror script paths in docs examples
Copilot Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions docs/release-team/mirror-scripts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,22 @@ RSYNCSOURCE=rsync://archive.ubuntu.mirror.isp.com/ubuntu
# Define where you want the mirror-data to be on your mirror
BASEDIR=/var/www/ubuntuarchive/

if [ ! -d ${BASEDIR} ]; then
if [ ! -d "${BASEDIR}" ]; then
warn "${BASEDIR} does not exist yet, trying to create it..."
mkdir -p ${BASEDIR} || fatal "Creation of ${BASEDIR} failed."
mkdir -p "${BASEDIR}" || fatal "Creation of ${BASEDIR} failed."
fi

rsync --recursive --times --links --safe-links --hard-links \
--stats \
--exclude "Packages*" --exclude "Sources*" \
--exclude "Release*" --exclude "InRelease" \
${RSYNCSOURCE} ${BASEDIR} || fatal "First stage of sync failed."
"${RSYNCSOURCE}" "${BASEDIR}" || fatal "First stage of sync failed."

rsync --recursive --times --links --safe-links --hard-links \
--stats --delete --delete-after \
${RSYNCSOURCE} ${BASEDIR} || fatal "Second stage of sync failed."
"${RSYNCSOURCE}" "${BASEDIR}" || fatal "Second stage of sync failed."

date -u > ${BASEDIR}/project/trace/$(hostname -f)
date -u > "${BASEDIR}/project/trace/$(hostname -f)"
```


Expand Down Expand Up @@ -102,15 +102,14 @@ RSYNCSOURCE=rsync://releases.ubuntu.mirror.isp.com/releases
# Define where you want the mirror-data to be on your mirror
BASEDIR=/var/www/ubuntureleases/

if [ ! -d ${BASEDIR} ]; then
if [ ! -d "${BASEDIR}" ]; then
warn "${BASEDIR} does not exist yet, trying to create it..."
mkdir -p ${BASEDIR} || fatal "Creation of ${BASEDIR} failed."
mkdir -p "${BASEDIR}" || fatal "Creation of ${BASEDIR} failed."
fi

rsync --verbose --recursive --times --links --safe-links --hard-links \
--stats --delete-after \
${RSYNCSOURCE} ${BASEDIR} || fatal "Failed to rsync from ${RSYNCSOURCE}."
"${RSYNCSOURCE}" "${BASEDIR}" || fatal "Failed to rsync from ${RSYNCSOURCE}."

date -u > ${BASEDIR}/.trace/$(hostname -f)
date -u > "${BASEDIR}/.trace/$(hostname -f)"
```

Loading