Feature/userinfo - #273
Open
JasonRobertFrancis wants to merge 44 commits into
Open
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 41.88% 37.12% -4.76%
==========================================
Files 986 1183 +197
Lines 49488 56762 +7274
Branches 5843 6169 +326
==========================================
+ Hits 20726 21072 +346
- Misses 27852 34759 +6907
- Partials 910 931 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment was marked as resolved.
This comment was marked as resolved.
…modal) and responds to code-quality bot userinfo recommendations
JasonRobertFrancis
force-pushed
the
feature/userinfo
branch
from
July 30, 2026 20:03
22567dc to
694ecd4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rlorenzo
reviewed
Aug 6, 2026
| { | ||
| [ApiController] | ||
| [Route("public/utilities")] | ||
| public class PublicPhotoController : ControllerBase |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| /// <param name="mailID">Mail ID</param> | ||
| /// <param name="altphoto">Use alternative photo</param> | ||
| /// <returns></returns> | ||
| [Route("/userPhoto")] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JasonRobertFrancis
force-pushed
the
feature/userinfo
branch
from
August 6, 2026 14:07
be9ecd0 to
e29d9a9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
JasonRobertFrancis
force-pushed
the
feature/userinfo
branch
from
August 6, 2026 18:57
3165238 to
8563ac5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Comment on lines
+231
to
+234
| catch (NullReferenceException ex) | ||
| { | ||
| Console.WriteLine($"Warning: PopulateDirectoryInfoAsync LDAP failed: {ex.Message}"); | ||
| } |
Comment on lines
+1725
to
+1732
| foreach (var middlePart in middleParts.Where(middlePart => middlePart.Length > 0)) | ||
| { | ||
| var variation = $"{name} {middlePart[0]}"; | ||
| if (!nameVariations.Contains(variation)) | ||
| { | ||
| nameVariations.Add(variation); | ||
| } | ||
| } |
Comment on lines
+293
to
+296
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine($"Warning: PopulateEmployeeInfoAsync failed: {ex.Message}"); | ||
| } |
Comment on lines
+374
to
+378
| catch (Exception ex) | ||
| { | ||
| // Exceptions during student info retrieval are caught and ignored to allow other directory details to load. | ||
| Console.WriteLine($"Warning: PopulateStudentInfoAsync failed: {ex.Message}"); | ||
| } |
Comment on lines
+394
to
+397
| catch | ||
| { | ||
| return null; | ||
| } |
Comment on lines
+423
to
+426
| catch | ||
| { | ||
| return null; | ||
| } |
Comment on lines
+442
to
+445
| catch | ||
| { | ||
| return null; | ||
| } |
Comment on lines
+461
to
+464
| catch | ||
| { | ||
| return false; | ||
| } |
Comment on lines
+480
to
+483
| catch | ||
| { | ||
| return null; | ||
| } |
Comment on lines
+499
to
+502
| catch | ||
| { | ||
| return "No"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.