Require supervising PI for genome-center-grp access requests#610
Open
ianandersonlol wants to merge 1 commit into
Open
Require supervising PI for genome-center-grp access requests#610ianandersonlol wants to merge 1 commit into
ianandersonlol wants to merge 1 commit into
Conversation
ianandersonlol
requested review from
jSylvestre,
sprucely and
srkirkland
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users request access to
genome-center-grp, Hippo now requires a supervising PI and keeps the modal confirm button disabled until one is selected.This is a very basic hardcoded implementation to make GC staff's lives easier. For
genome-center-grp, it is not obvious what lab a user is in the way it usually is when they request access to an individual lab account.Validation:
./node_modules/.bin/vitest run src/components/Account/AccountInfo.test.tsxnpx npm@10.9.2 run builddotnet build hippo.sln