Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
|
Contributor
|
📖 https://ucd-serg.github.io/serodynamics/preview/pr105 |
Kwan-Jenny
reviewed
Aug 6, 2025
Comment on lines
+17
to
+21
| #' - id_var = The ID of individuals included | ||
| #' - biomarker_var = The different antigen isotype combinations that are being | ||
| #' measured | ||
| #' - timeindays = The amount of time in days since symptom onset | ||
| #' - value_var = The measured assay value |
Collaborator
There was a problem hiding this comment.
Suggested change
| #' - id_var = The ID of individuals included | |
| #' - biomarker_var = The different antigen isotype combinations that are being | |
| #' measured | |
| #' - timeindays = The amount of time in days since symptom onset | |
| #' - value_var = The measured assay value | |
| #' - id_var = Unique identifier for each individual. | |
| #' - biomarker_var = Antigen-isotype combinations being measured (e.g., "~ IgG"). | |
| #' - timeindays = Time since symptom onset, in days. | |
| #' - value_var = Measured assay value (e.g., MFI-bg, OD, or concentration). |
Collaborator
There was a problem hiding this comment.
@sschildhauer I just left a suggestion for a possible change. You don't need to update it—it's just an example in case you find it helpful.
Kwan-Jenny
reviewed
Aug 6, 2025
Collaborator
Kwan-Jenny
left a comment
Kwan-Jenny
left a comment
There was a problem hiding this comment.
Everything looks clean and well structured. I left a minor suggestion for clarity, but no changes are necessary unless you prefer it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this pull request I am specifying the documentation for the run_mod data input. Here we are listing the different columns necessary for run_mod, including: id_var, biomarker_var, timeindays, and value_var. I am also including as_case_data as a reference for specifying these variables as attributes.