ci: add permissions and pin action SHAs (4 workflows) - #1646
Open
Alb3e3 wants to merge 2 commits into
Open
Conversation
Add `permissions: read-all` at the workflow level to enforce least-privilege for all jobs, and pin all third-party action references to full commit SHAs to prevent supply-chain attacks via mutable version tags or branch names.
Collaborator
|
I would want to see a dependabot config like https://github.com/OSGeo/gdal/blob/master/.github/dependabot.yml to update the SHAs |
Author
|
@rouault Done — I added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI workflows are missing top-level `permissions` declarations and reference actions by mutable version tags, which are supply-chain risk vectors.
Changes:
Mutable action references (`@v4`, `@main`, etc.) allow a compromised upstream action to run arbitrary code in your CI. Pinning to a commit SHA ensures only the audited version runs.