fix: issue #61 — 対角 self-distance の sqrt NaN 勾配を構造的に修正 - #64
Merged
Conversation
off-diagonal のみ sqrt を適用し対角は 0 のまま。ad-hoc eps なし。 Co-authored-by: Cursor <cursoragent@cursor.com>
dist_sq > 0 のみ sqrt を適用する構造的マスクに整理し、 厳密一致点・近接点の勾配健全性テストを追加する。 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43a0b98a6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
main の sqrt(NUMERICAL_EPS) 方式ではなく、dist_sq > 0 のみ sqrt を適用する 構造的修正を維持。test_topology の対角期待値を 0 に更新。 Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_anisotropic_distance_matrixでdist_sq == 0（対角 self-distance および coincident 点ペア）をsqrtの計算グラフから除外し、topo loss 学習時の NaN 勾配崩壊を防ぐsqrt(dist_sq)）Fixes #61
Test plan
uv run pytest tests/test_topology_gradients.py tests/test_topology.py -vuv run python -m tda_ml.main --config dev（topo loss 有効、3 epoch NaN なし完走）Made with Cursor