Use RECURSION variable in for-loop#35
Open
hpols wants to merge 1 commit intoudacity:masterfrom
hpols:patch-1
Open
Use RECURSION variable in for-loop#35hpols wants to merge 1 commit intoudacity:masterfrom hpols:patch-1
hpols wants to merge 1 commit intoudacity:masterfrom
hpols:patch-1
Conversation
To ensure the CantorGasket works with higher and lower recursions, use the variable and deduct one in the for-loop.
Kvaibhav01
reviewed
Aug 15, 2018
Kvaibhav01
left a comment
There was a problem hiding this comment.
Please tell me how this RECURSIONS works here?
Author
|
RECURSION is the global variable we defined holding the number of recursions. Following the suggestion this was 5. The commented out for-loop, which offers a tighter code, uses 4 (i.e. recursion - 1). I would thus suggest to actually do that calculation there instead of hard coding the result in. Like this, if for any reason the recursion is changed to a higher or lower number this will automatically adapt maintaining the effect we want. |
Kvaibhav01
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure the CantorGasket works with higher and lower recursions, use the variable and deduct one in the for-loop.