Fix auth adapter runtime parity - #311
Conversation
🦋 Changeset detectedLatest commit: 634e092 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cadc6e5b7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| "kitcn": patch | |||
There was a problem hiding this comment.
Release the narrowed public context type as a minor
RunMutationCtx is publicly exported from kitcn/server, and this commit deliberately makes its third transactionLimits argument a type error, so existing consumers using that signature stop compiling. Classify this as a minor breaking change rather than a patch. .agents/rules/changeset.mdcL15-L19
Useful? React with 👍 / 👎.
🐛 Fixes ➖ N/A
🟢 95-100% confidence
bun check.✅ Outcome
Unbounded auth queries continue past 200 rows and abort pages that cannot make progress. Shared mutation contexts expose only the call shape valid from actions.
Browser proof is N/A for package runtime and type behavior. Fresh shadcn generation also advanced
lucide-reactfrom^1.27.0to^1.28.0in six generated fixture manifests; each targeted fixture check passes.🏗️ Design
limit.RunMutationCtx.runMutationfromGenericActionCtx.🧪 Verified
bun test packages/kitcn/src/auth/adapter.test.ts packages/kitcn/src/server/context-utils.test.tsbunx vitest run packages/kitcn/src/server/context-utils.test-d.ts@ts-expect-error, then passes after restoringGenericActionCtxbun --cwd packages/kitcn typecheckbun --cwd packages/kitcn buildnext,next-auth,start,start-auth,vite, andvite-authbun lint:fixbun check