Skip to content

Fix auth adapter runtime parity - #311

Merged
zbeyens merged 4 commits into
mainfrom
codex/sync-convex-auth-runtime-fixes
Jul 30, 2026
Merged

Fix auth adapter runtime parity#311
zbeyens merged 4 commits into
mainfrom
codex/sync-convex-auth-runtime-fixes

Conversation

@zbeyens

@zbeyens zbeyens commented Jul 30, 2026

Copy link
Copy Markdown
Member
  • Auto release

🐛 Fixes ➖ N/A

🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 Unbounded pagination, stalled-page termination, and action-safe typing failed before their owning fixes. ➖ N/A
Verified 🟢 31 focused tests, Convex 1.42 type regression, package build, and full bun check. ➖ N/A

✅ Outcome

Unbounded auth queries continue past 200 rows and abort pages that cannot make progress. Shared mutation contexts expose only the call shape valid from actions.

⚠️ Caveat

Browser proof is N/A for package runtime and type behavior. Fresh shadcn generation also advanced lucide-react from ^1.27.0 to ^1.28.0 in six generated fixture manifests; each targeted fixture check passes.

🏗️ Design

  • Preserve the 200-row request cap while using an infinite total budget only when callers omit limit.
  • Require every non-final page to advance its cursor or produce rows/count.
  • Type RunMutationCtx.runMutation from GenericActionCtx.
  • Run the committed type regression against pinned Convex 1.42.3 while regular package gates keep the supported Convex 1.38 baseline.

🧪 Verified

  • bun test packages/kitcn/src/auth/adapter.test.ts packages/kitcn/src/server/context-utils.test.ts
  • bunx vitest run packages/kitcn/src/server/context-utils.test-d.ts
  • Production-revert type proof: fails with unused @ts-expect-error, then passes after restoring GenericActionCtx
  • bun --cwd packages/kitcn typecheck
  • bun --cwd packages/kitcn build
  • Targeted scenario sync/check for next, next-auth, start, start-auth, vite, and vite-auth
  • bun lint:fix
  • bun check
  • Final autoreview: TruffleHog clean; no accepted/actionable findings; patch correct at 0.91

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 634e092

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
kitcn Patch
@kitcn/resend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-convex Ready Ready Preview Jul 30, 2026 1:42pm

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cadc6e5b7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,8 @@
---
"kitcn": patch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Release the narrowed public context type as a minor

RunMutationCtx is publicly exported from kitcn/server, and this commit deliberately makes its third transactionLimits argument a type error, so existing consumers using that signature stop compiling. Classify this as a minor breaking change rather than a patch. .agents/rules/changeset.mdcL15-L19

Useful? React with 👍 / 👎.

@zbeyens
zbeyens merged commit 644ed41 into main Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant