Use Safe Parameters in flask Response set_cookie Call#64
Closed
pixeebot[bot] wants to merge 1 commit intodevelopfrom
Closed
Use Safe Parameters in flask Response set_cookie Call#64pixeebot[bot] wants to merge 1 commit intodevelopfrom
flask Response set_cookie Call#64pixeebot[bot] wants to merge 1 commit intodevelopfrom
Conversation
Contributor
Author
|
I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it? If this change was not helpful, or you have suggestions for improvements, please let me know! |
Contributor
Author
|
Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them! |
Contributor
Author
|
This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know! You can also customize me to make sure I'm working with you in the way you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This codemod sets the most secure parameters when Flask applications call
set_cookieon a response object. Without these parameters, your Flaskapplication cookies may be vulnerable to being intercepted and used to gain access to sensitive data.
The changes from this codemod look like this:
from flask import Flask, session, make_response app = Flask(__name__) @app.route('/') def index(): resp = make_response('Custom Cookie Set') - resp.set_cookie('custom_cookie', 'value') + resp.set_cookie('custom_cookie', 'value', secure=True, httponly=True, samesite='Lax') return respMore reading
I have additional improvements ready for this repo! If you want to see them, leave the comment:
... and I will open a new PR right away!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs | Codemod ID: pixee:python/secure-flask-cookie