fix: correct GitHub Pages directory structure and preserve PR #169 content#187
Conversation
- Delete docs/site/demo.html and docs/site/integration.html (unnecessary complexity) - Minimize docs/site/index.html content (remove hype, simplify to 3 features) - Add docs/site/css/styles.css (shared design system with glassmorphism) - Maintain comprehensive-demo.html as full-featured option Fortress-compliant: 4 files changed (≤5 limit) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Move comprehensive-demo.html from docs/site/ to website/ - Move CSS styles from docs/site/css/ to website/css/ - Remove incorrect simplified index.html (preserve enterprise version from PR #169) - GitHub Pages workflow already configured for website/ directory Resolves directory structure issue identified in PR review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reviewer's GuideThis PR realigns GitHub Pages to the correct website/ directory by moving demo, integration, and index files out of docs/site, introduces a new comprehensive CSS stylesheet under website/css, and preserves the enterprise-grade content from PR #169 including the full-featured index, demo, and integration pages. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRemoves several static docs/site and website demo/integration pages, centralizes styling into new external CSS files (css/styles.css and css/demo.css), updates website HTML to reference the external styles, and eliminates multiple client-side demo pages and their embedded scripts and assets. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser as Demo UI (browser)
participant API as Emotion API / Mock
participant ChartMgr as ChartManager
User->>Browser: submit text / click analyze
Browser->>Browser: show loading state
Browser->>API: request analysis (real API or simulation)
alt API success
API-->>Browser: emotion results
else API failure / missing
API-->>Browser: error -> Browser uses simulated results
end
Browser->>ChartMgr: destroy existing charts (safe/no-op)
ChartMgr-->>Browser: destroy confirmed
Browser->>ChartMgr: create/update charts (bar/doughnut)
ChartMgr-->>Browser: charts rendered
Browser->>User: display results, API info, hide loading
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @uelkerd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the project's web content by correcting the GitHub Pages directory structure. It ensures that all demo and styling assets are correctly located within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Here's the code health analysis summary for commits Analysis Summary
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Update all page links and navigation references to point to the new website/ paths to prevent broken links after the move.
- Consider splitting the large styles.css into modular files or removing unused CSS variables to improve maintainability and reduce payload.
- Verify that the interactive demo and integration pages are correctly included in the site build and that assets load properly from website/css/.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Update all page links and navigation references to point to the new website/ paths to prevent broken links after the move.
- Consider splitting the large styles.css into modular files or removing unused CSS variables to improve maintainability and reduce payload.
- Verify that the interactive demo and integration pages are correctly included in the site build and that assets load properly from website/css/.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the GitHub Pages directory structure by moving demo files from the incorrect docs/site/ directory to the proper website/ directory, while preserving comprehensive content from PR #169.
- Move CSS and demo files to correct GitHub Pages directory
- Remove incorrectly placed files from
docs/site/ - Preserve enterprise-grade content and branding
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/css/styles.css | Moves shared CSS from docs/site/ to correct website/ directory |
| docs/site/integration.html | Removes incorrectly placed integration guide |
| docs/site/index.html | Removes incorrectly placed enterprise homepage |
| docs/site/demo.html | Removes incorrectly placed demo page |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the website files from the docs/site/ directory to the correct website/ directory for GitHub Pages deployment. This is a good structural improvement. My main feedback is regarding the new website/css/styles.css file. While creating a shared stylesheet is an excellent step towards better code organization, the file is currently not linked in any of the HTML pages, making it unused. I've added a comment with suggestions to complete this refactoring.
| @@ -0,0 +1,170 @@ | |||
| /* Shared styles for SAMO-DL website */ | |||
There was a problem hiding this comment.
This new stylesheet is a great step towards centralizing styles for the website. However, it's currently not linked in any of the HTML files within the website/ directory (index.html, comprehensive-demo.html, etc.), which means these styles are not being applied and the file is effectively unused.
To complete this refactoring, you should:
- Link this stylesheet in the
<head>of the relevant HTML files (e.g.,<link rel="stylesheet" href="css/styles.css">). - Refactor the inline
<style>blocks in the HTML files to remove duplicated styles that are now defined here. - Ensure the styles in this shared file are consistent with the intended design across all pages. I noticed some discrepancies between this file and the inline styles (e.g., in
.hero-sectionandbodystyles inindex.htmlandcomprehensive-demo.html).
- Add shared styles.css with common components and variables - Add demo.css for demo-specific styling - Improve maintainability with external CSS files - Address Copilot AI feedback on SVG data URI and documentation
- Remove inline CSS from index.html and demo.html - Add external CSS links to styles.css and demo.css - Reduce code duplication and improve maintainability - Follows modular CSS architecture established
- Remove inline CSS from comprehensive-demo.html and integration.html - Add external CSS links to styles.css - Complete the CSS modularization refactor - Improve code maintainability and reduce duplication
- Remove demo.html and integration.html (redundant standalone pages) - Update index.html navigation: Home | Emotion Demo | Documentation - Point all 'Emotion Demo' links to comprehensive-demo.html - Remove 'All Features' and 'Team Integration' navigation items - Update comprehensive-demo.html to remove integration references - Remove Team Guides card that linked to integration Navigation simplified from 5 items to 3 items for better UX. Fortress compliance: 4 files changed (≤5 limit). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add all missing component styles from original inline CSS - Include demo-specific components (demo-container, demo-tab, result-card, etc.) - Add comprehensive styling for metrics, loading states, and interactive elements - Ensure full visual consistency with original design - Address Copilot AI feedback on missing styles and design discrepancies
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
website/css/styles.css (1)
168-201: Consolidate duplicate component styles
feature-card,btn-primary, the@keyframesblocks, and even.footerare each defined twice in this stylesheet (first earlier in the file, then again here). Keeping one canonical definition per selector avoids accidental drift and makes future maintenance easier.You can drop the earlier duplicate rules and keep this single, richer block, or merge the differences into one definition—for example:
-/* Initial feature-card definition (redundant) */ -.feature-card { - background: var(--glass-bg); - backdrop-filter: blur(15px); - border: 1px solid var(--glass-border); - border-radius: 20px; - box-shadow: var(--shadow-glass); - transition: var(--transition-bounce); - height: 100%; - color: inherit; - padding: 30px; - text-align: center; -} - -/* ... later duplicate with updated properties ... */ -.feature-card { - background: var(--glass-bg); - backdrop-filter: blur(20px); - border: 1px solid var(--glass-border); - border-radius: 20px; - box-shadow: var(--shadow-glass); - transition: var(--transition-bounce); - height: 100%; - color: #e2e8f0; -} +/* Single canonical feature-card definition */ +.feature-card { + background: var(--glass-bg); + backdrop-filter: blur(20px); + border: 1px solid var(--glass-border); + border-radius: 20px; + box-shadow: var(--shadow-glass); + transition: var(--transition-bounce); + height: 100%; + color: #e2e8f0; + padding: 30px; + text-align: center; +}Apply the same cleanup to the other duplicated selectors so each lives in one place.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
website/comprehensive-demo.html(1 hunks)website/css/styles.css(1 hunks)website/demo.html(0 hunks)website/index.html(16 hunks)website/integration.html(0 hunks)
💤 Files with no reviewable changes (2)
- website/demo.html
- website/integration.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Sourcery review
🔇 Additional comments (1)
website/comprehensive-demo.html (1)
19-20: External stylesheet hookup looks goodGreat to see the page now pulling from the shared
css/styles.css; this keeps the demo aligned with the rest of the site’s look and feel.
- Remove fixed sizing from .loading-spinner wrapper to prevent clipping - Move spinner animation and styling to .spinner-border inner element - Allow wrapper to size naturally while spinner maintains circular animation - Addresses CodeRabbit AI feedback on loading spinner overflow issue
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
website/css/styles.css (3)
75-93: Deduplicate the.feature-cardrules.The selector is defined twice with overlapping but diverging property sets, which makes future tweaks error-prone. Let's collapse this into a single definition to avoid silent regressions.
-.feature-card { - background: var(--glass-bg); - backdrop-filter: blur(15px); - border: 1px solid var(--glass-border); - border-radius: 20px; - box-shadow: var(--shadow-glass); - transition: var(--transition-bounce); - height: 100%; - color: inherit; - padding: 30px; - text-align: center; -} - -.feature-card:hover { - transform: translateY(-10px) scale(1.02); - box-shadow: var(--shadow-glow); -} - -/* Feature cards */ -.feature-card { - background: var(--glass-bg); - backdrop-filter: blur(20px); - border: 1px solid var(--glass-border); - border-radius: 20px; - box-shadow: var(--shadow-glass); - transition: var(--transition-bounce); - height: 100%; - color: #e2e8f0; -} +.feature-card { + background: var(--glass-bg); + backdrop-filter: blur(20px); + border: 1px solid var(--glass-border); + border-radius: 20px; + box-shadow: var(--shadow-glass); + transition: var(--transition-bounce); + height: 100%; + color: #e2e8f0; + padding: 30px; + text-align: center; +}Also applies to: 157-191
60-73: Consolidate.btn-primaryinto a single rule.We define the same selector twice with identical declarations. Keeping one authoritative block avoids drift if we tweak the style later.
-.btn-primary { - background: var(--primary-gradient); - border: none; - border-radius: 12px; - padding: 12px 30px; - font-weight: 600; - transition: var(--transition-bounce); - box-shadow: var(--shadow-glow); -} - -.btn-primary:hover { - transform: translateY(-2px) scale(1.05); - box-shadow: 0 15px 50px rgba(139, 92, 246, 0.4); -} - /* Buttons */ .btn-primary { background: var(--primary-gradient); border: none; border-radius: 12px; padding: 12px 30px; font-weight: 600; transition: var(--transition-bounce); box-shadow: var(--shadow-glow); }Also applies to: 257-270
350-401: Remove duplicate@keyframesdefinitions.
@keyframes floatand@keyframes fadeInUpare declared twice with the same content. Keeping a single declaration for each animation tightens the file and prevents conflicting edits later on.-/* Animations */ -@keyframes float { - 0%, 100% { transform: translateY(0px) rotate(0deg); } - 33% { transform: translateY(-20px) rotate(1deg); } - 66% { transform: translateY(-10px) rotate(-1deg); } -} - -@keyframes fadeInUp { - from { - opacity: 0; - transform: translateY(40px) scale(0.95); - } - to { - opacity: 1; - transform: translateY(0) scale(1); - } -} - /* Demo section */ .demo-section { background: rgba(0, 0, 0, 0.2);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
website/css/styles.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Sourcery review
Summary
docs/site/to properwebsite/directoryKey Changes
✅ Directory Structure Correction
comprehensive-demo.htmlfromdocs/site/→website/docs/site/css/→website/css/index.html(preserve enterprise version)✅ Content Preservation
website/index.htmlfrom PR feat: Add comprehensive demo website with DeBERTa v3 Large integration #169✅ Fortress Compliance
Directory Structure Impact
Before (Incorrect):
After (Correct):
GitHub Pages Configuration
website/directory ✅website/**✅References
simple_server.pyandstart-simple.shin commit b2cfee0🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Summary by Sourcery
Correct the GitHub Pages directory structure by moving demo assets and styles to the website directory, preserve existing enterprise content from PR #169, and introduce a full-featured interactive demo with updated UI styling.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Summary by CodeRabbit
Documentation
Style
Chores