Release/2.0.0#262
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the 2.0.0 release branch by aligning debug-only Settings debug behavior with production builds, adjusting SwiftPM compiler feature flags, and updating Xcode project metadata/settings for the app schemes/projects.
Changes:
- Make
SettingsViewModel’s debug initializer (and debug callback wiring) compile only under#if DEBUG, with a production-safe initializer for release builds. - Apply Swift upcoming feature
InternalImportsByDefaultto all build configurations inLokiPackagevia SwiftPM settings. - Update Xcode scheme/project upgrade metadata and adjust build settings in the Production project.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| LokiPackage/Sources/Features/Settings/Settings/SettingsViewModel.swift | Splits initializer signatures between Debug and Release builds to avoid debug-only dependencies in production. |
| LokiPackage/Package.swift | Changes SwiftPM swiftSettings so InternalImportsByDefault is enabled for all configurations. |
| App/Production.xcodeproj/xcshareddata/xcschemes/Production.xcscheme | Updates scheme upgrade version metadata. |
| App/Production.xcodeproj/project.pbxproj | Updates project upgrade check and build settings (incl. team + string catalog symbol generation). |
| App/Develop.xcodeproj/xcshareddata/xcschemes/Develop.xcscheme | Updates scheme upgrade version metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.