Upgrades for 2026#8
Merged
Merged
Conversation
According to the spec, it should have been `insert_final_newline`, but it was `insert_final_line`. Ref: https://spec.editorconfig.org
- Upgrade commitlint from 19.8.1 to 20.5.0 - Upgrade cspell from 9.0.1 to 10.0.0 - Upgrade ShellCheck from 3.1.0 to 4.1.0 - Upgrade stylelint from 14.16.1 to 17.8.0 - Upgrade sub-dependencies by nuking package lockfile
Since uicpharm/workflows is public now, we can use the lint-and-test.yml workflow.
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s “standardization” tooling baseline for 2026 by moving to a new Node version, modernizing lint tooling (notably Stylelint via stylelint-stylistic), and documenting recommended VS Code conventions.
Changes:
- Bump Node.js baseline to
v24.14.1and update npm version checks in scripts/docs. - Upgrade key lint/tooling dependencies (commitlint, cspell, markdownlint, shellcheck, stylelint) and migrate Stylelint stylistic rules to
@stylistic/*. - Add VS Code extension recommendations and document suggested VS Code settings.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/sample.sh |
Minor formatting/line fix at EOF. |
package.json |
Version bump to 0.5.0; updates npm check and multiple tooling dependencies; adds @stylistic/* packages. |
README.md |
Documents eslint modernization status, updates node check example, adds VS Code recommendations/settings. |
.vscode/extensions.json |
Adds recommended VS Code extensions list. |
.stylelintrc.json |
Adds @stylistic config/plugin and migrates stylistic rules to @stylistic/* names. |
.nvmrc |
Updates Node version to v24.14.1. |
.github/workflows/development.yml |
Switches CI to a reusable workflow in uicpharm/workflows. |
.editorconfig |
Fixes EditorConfig key to insert_final_newline. |
.cspell.json |
Formatting-only adjustment at EOF. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joshuacurtiss
force-pushed
the
jcurt/upgrades-2026
branch
from
ff06ced to
6a6d032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrade to standardization sets the stage for new 2026 development. Some key improvements:
Upgrading eslint to 10.x is going to be more involved, and will be done in-process as new Vue/JS work is done. Thus, this v0.5.0 release may be short-lived, and we may finally upgrade to v1.0.0 once we have Vue and JS linting set up with eslint 10.x.
Other note: Stylelint made a drastic change to drop its stylistic rules starting with Stylelint 15. This goes against our desires (and the desires of many other people). Stylelint's philosophy is that you should exclusively use Prettier. However, if you are using eslint for stylistic enforcement, it is useful to continue using Stylelint in such a way too, and not adopt Prettier which is especially opinionated. So, our approach has been to adopt stylelint-stylistic, which is a plugin that returns the style rules to Stylelint.