fix for correctness: maybe data is returned but is None or empty somehow#8
Open
echuber2 wants to merge 1 commit into
Open
fix for correctness: maybe data is returned but is None or empty somehow#8echuber2 wants to merge 1 commit into
echuber2 wants to merge 1 commit into
Conversation
I think it's possible that a field could be None or "" without triggering the exception, so we should explicitly mark the node invalid.
Contributor
Author
|
I've encountered at least one case in the wild where the SAML nameId came back null (None) despite there being an apparently fine user link in the GitHub web GUI. Besides adjusting the code slightly here to make sure this is flagged properly, and not knowing why this would happen, I guess the fix might be to revoke that user's SSO connection manually and ask them to re-authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's possible that a field could be None or "" without triggering the exception, so we should explicitly mark the node invalid.