Skip to content

Conversation

@clmould
Copy link
Collaborator

@clmould clmould commented Jan 21, 2026

Description

removed ixc=60 from low aspect ratio demo input file

Outputs:
low_aspect_ratio_DEMO_results.zip

Regression test failures:

image image image image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.51%. Comparing base (7c48754) to head (f5a9366).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4057   +/-   ##
=======================================
  Coverage   46.51%   46.51%           
=======================================
  Files         123      123           
  Lines       28802    28802           
=======================================
  Hits        13398    13398           
  Misses      15404    15404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Jan 21, 2026
Copy link
Collaborator

@ajpearcey ajpearcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. not sure why the regression test is failing, is this because the number of iteration variables has changed.

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two possible causes for the regression failure:

  1. The removal of the iteration variable changes the path of the solver and it converges on a slightly different solution
  2. The number of iteration variables has changed so the output ordering has changed this is because the iteration variable data in the MFile uses sequential numbers, not the iteration variable number.

@timothy-nunn timothy-nunn merged commit 311e5b3 into main Jan 22, 2026
16 of 20 checks passed
@timothy-nunn timothy-nunn deleted the fix-c-tf-turn-error-in-low-aspect-demo-file branch January 22, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants