-
Notifications
You must be signed in to change notification settings - Fork 17
Fix c tf turn error in low aspect demo file #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c tf turn error in low aspect demo file #4057
Conversation
tmargmin_cs -> tmargmin fvsbrnni -> f_c_plasma_non_inductive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4057 +/- ##
=======================================
Coverage 46.51% 46.51%
=======================================
Files 123 123
Lines 28802 28802
=======================================
Hits 13398 13398
Misses 15404 15404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. not sure why the regression test is failing, is this because the number of iteration variables has changed.
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two possible causes for the regression failure:
- The removal of the iteration variable changes the path of the solver and it converges on a slightly different solution
- The number of iteration variables has changed so the output ordering has changed this is because the iteration variable data in the MFile uses sequential numbers, not the iteration variable number.
Description
removed ixc=60 from low aspect ratio demo input file
Outputs:
low_aspect_ratio_DEMO_results.zip
Regression test failures:
Checklist
I confirm that I have completed the following checks: