bugfix/handle-branch-merges-commit-trailers #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopkinsmade
force-pushed
the
bugfix/handle-branch-merges-commit-trailers
branch
2 times, most recently
from
7e361ad to
4a9664c
Compare
…om a PR Signed-off-by: DBT pre-commit check
chopkinsmade
force-pushed
the
bugfix/handle-branch-merges-commit-trailers
branch
from
4a9664c to
1ca7d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Check if the current commit being scanned is from a merged PR. If this is true, skip the check for the signed-off-by trailer
Why
Commits from a merged PR will not have the signed-off-by git trailer as these commit messages are created by GitHub. This will cause the check on the pre-commit hooks to fail as they need the trailer present on the commit
How this has been tested
Reviewer Checklist