py3: remove unused storage_items()#2335
Merged
Merged
Conversation
Owner
|
will need a rebase plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex found inconsistency bug. We should use
append, notaddwithitems = [].This should raise an exception, but it didn't.... Why? It's because this code is not being used anywhere... so just remove it.
Also, Idk why modules would want access to other module storage. I mean, I could see some benefits in doing that, butif it's not needed, go ahead and remove it instead of fixing it.Consistency fix for dead code.