Skip to content

Drop the stale git source allowances from deny.toml - #420

Merged
onuralpszr merged 2 commits into
mainfrom
chore-deny-stale-git-sources
Aug 11, 2026
Merged

Drop the stale git source allowances from deny.toml#420
onuralpszr merged 2 commits into
mainfrom
chore-deny-stale-git-sources

Conversation

@onuralpszr

@onuralpszr onuralpszr commented Aug 11, 2026

Copy link
Copy Markdown
Member

Cargo.lock resolves every dependency from crates.io and contains no git sources, so the allow-git entry for the ort repository and the sources.allow-org block for ultralytics no longer apply to anything.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Removed obsolete Git source allowances from deny.toml because the current Cargo.lock contains no Git-based dependencies.

📊 Key Changes

  • Deleted the allow-git entry for https://github.com/pykeio/ort.git.
  • Removed the [sources.allow-org] configuration that allowed GitHub sources under ultralytics.
  • Retained the existing crates.io registry configuration and warnings for unknown registries and Git sources.

🎯 Purpose & Impact

  • Dependency source validation no longer permits the unused ort Git repository or Ultralytics GitHub sources.
  • No user-facing change.

Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @onuralpszr, thank you for submitting a ultralytics/inference 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/inference main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the complete deny.toml change and verified the repository has no git sources or active references to the removed allowances. The cleanup does not alter current dependency resolution or cargo-deny behavior for existing dependencies. LGTM.

@onuralpszr
onuralpszr merged commit 7267f78 into main Aug 11, 2026
12 of 13 checks passed
@onuralpszr
onuralpszr deleted the chore-deny-stale-git-sources branch August 11, 2026 11:01
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #420 has been merged—thank you, @onuralpszr!

“Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.” — Antoine de Saint-Exupéry

Your cleanup keeps deny.toml aligned with the current Cargo.lock by removing obsolete Git source allowances while preserving the existing registry safeguards, with no user-facing change.

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants