Delete the success and section log macros that nothing calls - #421
Conversation
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
|
👋 Hello @onuralpszr, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the logging macro removal and repository-wide call sites. The deletion is internally unused, but it removes two exported macros and therefore introduces a downstream compilation compatibility break. No other issues found.
💬 Posted 1 inline comment
- 💡 MEDIUM
src/logging.rs:47These macros are part of the public crate API because#[macro_export]makes them callable asultralytics_inference::success!andultralytics_inference::section!. Any downstream crate using either macro will fail to compile after upgrading, even though this repository has no call sites. Please retain them (possibly deprecated) or make this removal as part of an explicitly versioned breaking API release.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 PR #421 has been merged—thank you, @onuralpszr!
This cleanup removes the unused |
Neither macro has a single call site in
src,crates,examples,tests, the READMEs, ordocs;info!,warn!,error!, andverbose!are the ones actually in use. Both are#[macro_export]ed, so they are reachable asultralytics_inference::success!andultralytics_inference::section!by downstream crates even though nothing here uses them.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Removed the unused exported
success!andsection!logging macros fromsrc/logging.rsto eliminate unreferenced API surface.📊 Key Changes
success!macro, which printed bold green success messages.section!macro, which conditionally printed bold cyan section headers in verbose mode.info!,warn!,error!, andverbose!logging macros.🎯 Purpose & Impact
ultralytics_inference::success!orultralytics_inference::section!.