Skip to content

Make Codecov upload best effort - #93

Merged
glenn-jocher merged 1 commit into
mainfrom
fix/codecov-best-effort
Jul 9, 2026
Merged

Make Codecov upload best effort#93
glenn-jocher merged 1 commit into
mainfrom
fix/codecov-best-effort

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary\n- make the Codecov upload step non-blocking\n- keep existing coverage files, OIDC, flags, and plugins settings\n\n## Validation\n- ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml")'\n- git diff --check

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improves CI reliability by making Codecov coverage uploads non-blocking ✅

📊 Key Changes

  • Added continue-on-error: true to the Codecov upload step in GitHub Actions.
  • Changed Codecov setting fail_ci_if_error from true to false.
  • Keeps coverage reporting enabled while preventing external upload issues from failing the entire CI pipeline.

🎯 Purpose & Impact

  • Reduces false CI failures caused by temporary Codecov outages, network issues, or upload errors 🚀
  • Helps developers focus on actual test and code failures instead of third-party service problems.
  • Maintains visibility into test coverage without making it a required gate for PR success 📈

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops fixed Bug has been resolved labels Jul 9, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/template 🚀 PR! This automated message confirms we received your contribution, and an Ultralytics engineer will assist with review soon. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/template main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

No issues found. The workflow change is minimal and aligns with the PR goal of making Codecov uploads best-effort without altering the existing coverage configuration.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@glenn-jocher
glenn-jocher merged commit b8a3eee into main Jul 9, 2026
14 checks passed
@glenn-jocher
glenn-jocher deleted the fix/codecov-best-effort branch July 9, 2026 14:17
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🚀 Merged — thank you @glenn-jocher for improving CI reliability!

“The impediment to action advances action. What stands in the way becomes the way.” — Marcus Aurelius

This update turns a common CI obstacle into a smoother workflow by keeping Codecov reporting enabled while preventing temporary external upload failures from blocking valid PRs. It helps contributors stay focused on real test and code issues, reduces false negatives, and keeps development moving with greater confidence.

Appreciate the thoughtful improvement! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops GitHub Devops or MLops fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants