COCOS-584 - Support multiple kbs#587
Open
SammyOina wants to merge 4 commits intoultravioletrs:mainfrom
Open
Conversation
jovan-djukic
approved these changes
Mar 27, 2026
…nd datasets to specify individual KBS URLs. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…thin the CLI struct, and add algorithm type to agent's algorithm structure. Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 68.36% 68.31% -0.06%
==========================================
Files 116 116
Lines 7344 7389 +45
==========================================
+ Hits 5021 5048 +27
- Misses 1746 1764 +18
Partials 577 577 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Per-resource KBS configuration: algorithm and dataset KBS URLs now specified individually instead of globally
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
sequenceDiagram participant Client participant AgentService participant RemoteSource participant KBS participant Algorithm Client->>AgentService: InitComputation (with per-resource KBS) rect rgba(100, 150, 200, 0.5) note over AgentService: Download Algorithm AgentService->>RemoteSource: Fetch Algorithm alt Algorithm.KBS enabled RemoteSource->>KBS: Fetch decryption key (per-algo KBS URL) KBS-->>RemoteSource: Decryption provider end RemoteSource-->>AgentService: Encrypted algorithm AgentService->>AgentService: Decrypt & extract (type-aware) end rect rgba(150, 100, 200, 0.5) note over AgentService: Download Datasets loop Each Dataset AgentService->>RemoteSource: Fetch Dataset alt Dataset.KBS enabled RemoteSource->>KBS: Fetch decryption key (per-dataset KBS URL) KBS-->>RemoteSource: Decryption provider end RemoteSource-->>AgentService: Encrypted dataset AgentService->>AgentService: Decrypt & decompress end end rect rgba(200, 150, 100, 0.5) note over Algorithm,AgentService: Run with Concurrency Safety AgentService->>Algorithm: Run (mutex-protected) Algorithm->>Algorithm: Lock mutex Algorithm->>Algorithm: Start process Algorithm->>Algorithm: Unlock mutex Algorithm-->>AgentService: Running AgentService->>Algorithm: Stop (when needed) Algorithm->>Algorithm: Lock mutex Algorithm->>Algorithm: Kill process Algorithm->>Algorithm: Unlock mutex end AgentService->>AgentService: Cleanup (remove temp files) AgentService-->>Client: Results