fix(chocolatey): pass community verification (log path + PNG icon)#61
Merged
Conversation
The single-quoted PowerShell string kept the $env:TEMP / $packageName / $env:chocolateyPackageVersion subexpressions as literal text, so MSI received an invalid log path and aborted with exit 1622. Pre-compute the path in a double-quoted string and embed it via escaped inner quotes so %TEMP% values with spaces still resolve correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
256x256 PNG-encoded frame copied byte-for-byte from app.ico (no re-encoding). Needed for Chocolatey's iconUrl guideline which requires PNG or SVG (not ICO). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Chocolatey's package guidelines require iconUrl to resolve to a PNG or SVG asset, not ICO. SHA-pinned to ad0ea18 so the URL is stable even before the branch merges to main and survives branch deletion afterwards. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AThraen
force-pushed
the
feat/chocolatey-package
branch
from
3218150 to
0c556f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes that brought v0.5.0 through community.chocolatey.org verification after the initial submission failed:
silentArgswas a single-quoted PowerShell string, so$($env:TEMP)\...was passed literally to msiexec, which couldn't open it. Pre-compute the log path in a double-quoted string and embed it via escaped inner quotes so%TEMP%paths with spaces still resolve.iconUrlmust be PNG/SVG (not ICO) — extracted the 256×256 PNG frame fromapp.icobyte-for-byte (no re-encoding) and pinnediconUrlto the commit SHA so the URL is stable now and after this branch merges.Both fixes were live-verified by re-dispatching the publish workflow against
v0.5.0:choco push✅Test plan
chocolateyinstall.ps1syntax-checked via AST parsersilentArgsdry-run shows correctly-expanded%TEMP%path with proper quotingiconUrlpre-verified200 OK image/pngonraw.githubusercontent.com🤖 Generated with Claude Code