Add commit step before tagging to internal.md.#334
Merged
yujiahu415 merged 1 commit intoumyelab:masterfrom Jan 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at the release process documented in "internal.md",
and I believe it's missing a commit step.
Probably a strong git user would know to commit before tagging, but
I'm submitting this PR in case you agree it's better to have the step spelled out.
If you disagree, and want to reject the PR, no problem.
(The reason I was looking at this internal.md is that for a feature that checks LabGym to see if its clean/genuine vs. customized, one of the final steps is to get the software's signature (hash) and store it, for reference.
If you're going to store it inside of LabGym, then, do it after updating version in init.py, and right before that final commit -- which I found to be missing.)