Skip to content

Tidying up language issues#25

Open
HammyHavoc wants to merge 29 commits into
uncatcrea:masterfrom
HammyHavoc:master
Open

Tidying up language issues#25
HammyHavoc wants to merge 29 commits into
uncatcrea:masterfrom
HammyHavoc:master

Conversation

@HammyHavoc

Copy link
Copy Markdown
Contributor

Fixed typos and grammar, improved aesthetics and readability.

@HammyHavoc HammyHavoc changed the title Fixed a typo. Tidying up language issues Dec 4, 2014
@mleroi

mleroi commented Dec 7, 2014

Copy link
Copy Markdown
Collaborator

Thanks for those language and aesthetics fixes, that's really nice, and important for us as we're not natives :)

There's just one issue I'm not sure about : the 5 commits concerning "web services synchronization formatting bug" in build.php and simulator.php. WP AppKit implements a set of different web services to retrieve WP content : for now there are 3 web services :

  • synchronization, (used at app initialization and refresh)
  • comments, (retrieve post comments)
  • component (to retrieve more posts in a component's post list)
    (they can be found here : wp-app-kit/lib/web-services/core-web-services)
    And more web services will come later.

That's why I displayed separately : "Web services" (can be seen as the tiltle of the section) and "Synchronization" which is one of the available web services. We could display the url of the 2 other web services ("Comments" and "Component"), but they are not so important as the "synchronization" one, and they require a parameter in the url (the post ID for "comments", and the component id for "component") so we can't display a general link as we do for the synchronization web service.

For now, as we only display the synchronization web service, maybe we could write "Synchronization Web Service" but, I think, not "Web Services Synchronization" as in your last commit, because it's not the synchronization of the web services, but the web service called "synchronization" :)

What do you think?

@HammyHavoc

Copy link
Copy Markdown
Contributor Author

Undid that change I made in regards to web service synchronization, you should be able to merge now without any issues. Thanks for the feedback, friends. (- : 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants