Reintroduces the option to hide the Media Flyout when clicking on the…#670
Closed
The-Doggo wants to merge 1 commit intounchihugo:masterfrom
Closed
Reintroduces the option to hide the Media Flyout when clicking on the…#670The-Doggo wants to merge 1 commit intounchihugo:masterfrom
The-Doggo wants to merge 1 commit intounchihugo:masterfrom
Conversation
github-actions
bot
added
MainWindow / Media Flyout
2 tasks
… Taskbar Widget, moves it to the Media Flyout settings and implements recommendations from original code review. - This partially reverts commit 37c1097 ("Removed Taskbar Widget Clickable and Closeable in settings"). - This implements the code review unchihugo@37c1097#r2969772139 . - This moves the TaskbarWidgetClickable option form TaskbarWidgetPage to MediaFlyoutPage, corrects grid row index and refactors row difinitions in TaskbarWidgetPage and MediaFlyoutPage
The-Doggo
force-pushed
the
reintroduce-taskbar-options
branch
from
234db9a to
b5f8af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reintroduces the option to hide the Media Flyout when clicking on the Taskbar Widget, moves it to the Media Flyout settings and implements recommendations from original code review.
Motivation
#668
Closes 668
Type of Change
What Changed
Additional Information
Checklist