Scrolling Text for Song & Artist Name (ref #576)#674
Open
galagyy wants to merge 21 commits intounchihugo:masterfrom
Open
Scrolling Text for Song & Artist Name (ref #576)#674galagyy wants to merge 21 commits intounchihugo:masterfrom
galagyy wants to merge 21 commits intounchihugo:masterfrom
Conversation
- Add dedicated "App Filter" page - Add "App Filtering" menu card and navigation item - Add app filtering properties to settings storage - Add app filtering keys to en-US dictionary - Update main menu to use `GetActiveMediaSession()` over `GetFocusedSession()` - Update control click handlers to use `GetActiveMediaSession()`
- Update formatting from K&R to BSD (C# standard)
- Add taskbar & flyout refresh once a filter has been updated
- Update `PlayPause_Click()` in both `MainWindow.xaml.cs` and `TaskbarWidgetControl.xaml.cs` to use `TryTogglePlayPauseAsync()` over the previous keyboard approach to respect app filtering - Update UI logic to check `PlaybackStatus` over `Controls.IsPauseEnabled` to prevent desync from filters NOTE: ControlPlayPause opacity has been moved outside of the conditional due to making more sense there.
- Removed the `ExtractAppName()` function in favor of using the already-existing `getMediaPlayerData()` function
- Reintroduced early return statement - Renamed `taskbarSession` back to `focusedSession` - Removed unneeded else indentation
- Replaced malformed unicode with proper copyright unicode
- Move the app filtering feature to the system menu
- Fix `.exe` parsing when adding custom application - Inverted if statements for easier readability - Changed type casting to use the `as` keyword for readability
- Update app comparison to compare manual additions against dropdown selections - Move `.exe` comparison within new comparison method
- Added documentation to all methods for future maintenance
- Change page wording to be more intuitive - Reformat UI to be more friendly
- Add disk caching for app icons as apps may not always be open - Add `AppNameIconConverter` to convert an apps name to an icon matching the app using memory cache or disk
- Add dedicated whitelist/blacklist mode - Add app icon for apps in either entry - Add padding to dropdown entries - Update dictionary entries to match new scheme
- Revert `MediaPlayerData` to use previous implementation - Remove `AppNameIconConverter` as it's no longer needed - Remove app icons from the whitelist/blacklist UI
- Add scrolling text option to the taskbar widget
- Add option to enable or disable scrolling on the artist's name
- Fix scroll to only occur when the song length is past the max length
github-actions
bot
added
MainWindow / Media Flyout
Author
|
As noted above, this is built with commits from another open PR; I am unsure of what the behavior would be for merging. |
galagyy
changed the title
- Add two words for infinite scrolling (no more empty text space) - Add small gradient to left and right ends
- Fix logic for scrolling whilst paused
Owner
|
Hi @galagyy, looks like you've included the changes made in your other branch here as well. Are you able to separate the changes so it's easier for me to review the code? Thank you! |
Author
|
Hello, thanks for the response! I'll wait for the other one to merge cleanly and then try recreating a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a feature where the song's name or artist's name may scroll if they do not fit the taskbar widget.
This only applies to the widget, and no implementation has been made for the media flyout.
Motivation
Aims to resolve #576
Type of Change
What Changed
Additional Information
NOTE: This PR is built upon the branch in pull request no. 652
Scroll settings:
Example with settings above:
https://github.com/user-attachments/assets/1e367948-e442-4bad-890c-fe60af9b2d54
Note that this is with infinite scrolling on; if infinite scrolling is disabled, the text will just go back and forth like on Spotify.
Checklist