Second submission for challenge#5
Open
JavierGelatti wants to merge 63 commits intounclebob:masterfrom
Open
Conversation
…shooting in circle
I discovered an implemented feature that was not tested.
Then, I had to choose between two paths:
1. Deleting the feature (if it's not in the requirements, then it
should not be in the code), or
2. Adding a test, to justify the existence of the feature.
I chose to add a new test (2), because I wanted to practice with FitNesse,
but in a real project I would consider the other option a little more (an
arrow can travel at most 103 caverns? and it isn't in the requirements?
sounds suspicious...)
Put things where I expected them to be
… to Game. Reorder a few things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing my first submission, I enjoyed so much while refactoring that I got a little carried away, and well... This submission does not add any features, but the code is heavily refactored.
I did it only for the sake of the learning experience, I am aware that maybe a refactoring was not necessary at all. In any case, any feedback on the modifications will be highly appreciated! :)