Conversation
The previous approach would fail in these two cases: 1. No Python installed: `run.sh` exited immediately with "python3 not found". 2. Debian/Ubuntu system Python: `ensurepip` module doesn't work as the maintainers want users to use system packages. To make things easier, we can instead use `uv` (downloading it if necessary) to manage the Python interpreter and the dependencies. `uv` is also much faster, which should decrease the chance of timeouts when the plugin is run for the first time. The only problem we should have now is the lack or wget or curl, but that seems less likely.
mark-undoio
approved these changes
Jan 19, 2026
Contributor
mark-undoio
left a comment
mark-undoio
left a comment
There was a problem hiding this comment.
Looks good to me from a read through. As discussed, I will also try to test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach would fail in these two cases:
run.shexited immediately with "python3 not found".ensurepipmodule doesn't work as the maintainers want users to use system packages.To make things easier, we can instead use
uv(downloading it if necessary) to manage the Python interpreter and the dependencies.uvis also much faster, which should decrease the chance of timeouts when the plugin is run for the first time.The only problem we should have now is the lack or wget or curl, but that seems less likely.