Add a --symbol-file flag to "delve replay" for external symbols.#48
Open
mark-undoio wants to merge 1 commit intoundo-v1.23.1from
Open
Add a --symbol-file flag to "delve replay" for external symbols.#48mark-undoio wants to merge 1 commit intoundo-v1.23.1from
mark-undoio wants to merge 1 commit intoundo-v1.23.1from
Conversation
This allows a separate debug symbol file to be specified when replaying a recording with the Undo backend. This can be used to supply debug information when the main binary has been stripped.
undo-bkenward
approved these changes
Mar 19, 2025
Contributor
undo-bkenward
left a comment
undo-bkenward
left a comment
There was a problem hiding this comment.
This makes sense. It'd be great to get this upstream, with rr backend support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for review purposes only.
This allows a separate debug symbol file to be specified when replaying a recording with the Undo backend.
This can be used to supply debug information when the main binary has been stripped.