Conversation
mark-undoio
left a comment
mark-undoio
left a comment
There was a problem hiding this comment.
Some very minor comments.
I take it we didn't need to materially change how our patches work as part of this port? Was there anything unusual required in the rebase?
service/test/integration1_test.go
Outdated
| @@ -0,0 +1,1096 @@ | |||
| package service_test | |||
There was a problem hiding this comment.
I think we've resurrected a test here because we used to have renaming in it. Possibly it's related to the deprecated (or removed?) RPC protocol version 1.
I suspect we can drop it (thought I'd caught all these before but probably I did not)
There was a problem hiding this comment.
Should now be gone....
service/test/integration1_test.go
Outdated
| @@ -1,1096 +0,0 @@ | |||
| package service_test | |||
There was a problem hiding this comment.
And here we've deleted it! It looks like this is a result of me fixing it up badly last time.
There was a problem hiding this comment.
Should now be gone....
| golang.org/x/exp/constraints | ||
| golang.org/x/exp/maps | ||
| golang.org/x/exp/slices | ||
| # golang.org/x/mod v0.20.0 |
There was a problem hiding this comment.
Did we intend to add these (and their associated license files)?
There was a problem hiding this comment.
I think these are for semver which we use for checking the udb version number is new enough.
In Undo, debuggee state is immutable during replay, so reading the G pointer via code injection won't work; and in any case, this approach is simpler.
* Update the documentation to mention UDB or LiveRecorder alongside rr. * Add makefile support for testing the Undo backend. * Add DLV_RECORD_REPLAY_BACKEND environment variable which overrides the record-replay backend, for use in GoLand. * Implement checkpoints as a map from checkpoint number to time. * Suppress resume call after restart. * Implement "when" command using "get_time" serial command. * Implement call injection using "set_debuggee_volatile". * Implement "restart" using "goto_time". * Enable or disable Undo backend appropriately in test cases.
This allows a separate debug symbol file to be specified when replaying a recording with the Undo backend. This can be used to supply debug information when the main binary has been stripped.
The error handling here was a bit painful but only needs doing in these two places (for now).
This is made compatible with UDB's bookmarks by using the UDB bookmark name as the "Note" field in Delve. To save Delve checkpoints, the "Note" must be made unique, so as to be a valid bookmark name in UDB.
Since we added support for a process tree level UUID the `vUDB;get_recording_ids` serial protocol message can return 4 UUIDs. It's easiest to just handle this unconditionally for now, we can clean up the legacy support later.
UDB now saves some additional paths to the session file. We don't do anything with these paths, but we need to be aware of them.
undo-bkenward
force-pushed
the
undo-v1.26.0
branch
from
37bc49e to
84902b8
Compare
4 participants
This pull request represents the differences between upstream Delve v1.26.0, and our fork at the same version. It is for review and not for merge.