Fixed reported error which occurs during the app icon extraction#142
Merged
Conversation
zehnm
requested changes
May 5, 2026
Contributor
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
Thanks for the fix!
The logic is correct and using .get() at line 670 fixes the KeyError.
Just a few small things to improve, then it's ready to merge.
Contributor
|
If you don't mind I'll add and push the small changes to merge this PR later today. |
zehnm
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Markus @zehnm,
I fixed the reported error on discord which occurs during the app icon extraction for homescreen apps