Fix metadata icon data path handling#66
Merged
Merged
Conversation
Only store the image filename instead of the full file path. This allows for a future migration of the downloaded metadata. The `UC_DATA_HOME` location cannot be considered static. Furthermore, using relative paths only worked if the `UC_DATA_HOME` was the working directory. This is not the case on the Remote device.
Add missing French & German translations
zehnm
force-pushed
the
fix/metadata-handling
branch
from
62b6acb to
fb633a6
Compare
The cache file is automatically created and doesn't need to exist at driver startup. This allows an easier installation on the Remote device and simply wiping the data cache directory in the future to remove the cache.
Add initial unit tests and rename the intg-androidtv source directory to src. This was required to make the unit tests work and also follows common project setup practices.
Most app icons look pretty good with this resolution while keeping a small size. Since the app icons are encoded as base64 data and sent over WebSockets, it's important to keep the size as small as possible. Once we allow file sharing from an integration, the UI can directly access the files and the image size can be increased up to 480x480.
Contributor
Author
|
Tested on the device: image data handling works great with the asyncio rewrite from PR #67. There are some app image glitches with Cast artwork (seen with Stremio): Cast artwork & app metadata is toggled a few times until the Cast artwork remains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase app icon size to 240x240 for better image quality and still keeping a small size for transferring as base64 data in WebSocket messages.
Only store the image filename instead of the full file path.
This allows for a future migration of the downloaded metadata. The
UC_DATA_HOMElocation cannot be considered static. Furthermore, using relative paths only worked if theUC_DATA_HOMEwas the working directory. This is not the case on the Remote device.Store the new homescreen icon in
UC_CONFIG_HOME.The data directory can be deleted at any time. It also makes it easier to add a user option to clear the image cache.
Resize homescreen icon to better fit the device screen and reduce runtime overhead.
Furthermore, the image is only loaded and converted to base64 once, then reused.
Add missing French & German translations in setup flow.
Label Cast & Google Play metadata as preview features in setup flow configuration.
Filter out all base64 encoded images in log messages to reduce runtime overhead and log flooding.
Refactor project structure: rename
intg-androidtvtosrc, and add initial unit tests.