Skip to content

Fix media_image_url attribute filtering #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zehnm merged 2 commits into from
May 14, 2025
Merged

Fix media_image_url attribute filtering #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3c73b
chore: add missing test cases for filter_data_img_properties
zehnm May 14, 2025
850c245
fix: media_image_url attribute filtering
zehnm May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
androidtvremote2==0.2.1
ucapi==0.3.0
ucapi==0.3.1
pyee~=13.0.0
google_play_scraper==1.2.7
pillow>=11.2.1
Expand Down
12 changes: 12 additions & 0 deletions tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,25 @@ def test_data_with_non_data_uri_icon(self):
data = {"icon": "http://example.com/icon.png"}
result = filter_data_img_properties(data)
self.assertEqual(result, data)
self.assertEqual(data, {"icon": "http://example.com/icon.png"})

def test_data_with_data_uri_icon(self):
data = {"icon": "data:image/png;base64,somedata"}
result = filter_data_img_properties(data)
self.assertEqual(result["icon"], "data:***")
self.assertEqual(data["icon"], "data:image/png;base64,somedata")

def test_data_with_media_image_url(self):
data = {MediaAttr.MEDIA_IMAGE_URL: "data:image/png;base64,somedata"}
result = filter_data_img_properties(data)
self.assertEqual(result[MediaAttr.MEDIA_IMAGE_URL], "data:***")
self.assertEqual(data[MediaAttr.MEDIA_IMAGE_URL], "data:image/png;base64,somedata")

def test_msg_data_with_attributes(self):
data = {"msg_data": {"attributes": {MediaAttr.MEDIA_IMAGE_URL: "data:image/png;base64,somedata"}}}
result = filter_data_img_properties(deepcopy(data))
self.assertEqual(result["msg_data"]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:***")
self.assertEqual(data["msg_data"]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:image/png;base64,somedata")

def test_msg_data_list_with_attributes_mixed(self):
data = {
Expand All @@ -46,7 +50,10 @@ def test_msg_data_list_with_attributes_mixed(self):
}
result = filter_data_img_properties(deepcopy(data))
self.assertEqual(result["msg_data"][0]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:***")
self.assertEqual(data["msg_data"][0]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:image/png;base64,somedata")

self.assertEqual(result["msg_data"][1]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "http://example.com/icon.png")
self.assertEqual(data["msg_data"][1]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "http://example.com/icon.png")

def test_msg_data_list_with_attributes(self):
data = {
Expand All @@ -59,6 +66,9 @@ def test_msg_data_list_with_attributes(self):
self.assertEqual(result["msg_data"][0]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:***")
self.assertEqual(result["msg_data"][1]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:***")

self.assertEqual(data["msg_data"][0]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:image/png;base64,somedata")
self.assertEqual(data["msg_data"][1]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "data:image/png;base64,somedata")

def test_no_modifications_needed(self):
data = {
"icon": "http://example.com/icon.png",
Expand All @@ -67,6 +77,8 @@ def test_no_modifications_needed(self):
}
result = filter_data_img_properties(deepcopy(data))
self.assertEqual(result, data)
self.assertEqual(result[MediaAttr.MEDIA_IMAGE_URL], "http://example.com/image.png")
self.assertEqual(result["msg_data"][0]["attributes"][MediaAttr.MEDIA_IMAGE_URL], "http://example.com/image.png")


if __name__ == "__main__":
Expand Down