#57, #55 Update inclusion proof verification, add cbor tags#59
#57, #55 Update inclusion proof verification, add cbor tags#59b3y0urs3lf merged 18 commits intoissue-52from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a major refactoring of the SDK, introducing InclusionCertificate and ShardId while standardizing CBOR tagging and versioning across API components. The Merkle tree implementation was moved to a new smt package and updated to a radix-based approach. Review feedback identifies a high-severity bug in the popcount logic of InclusionCertificate caused by signed byte extension. Furthermore, improvements are needed for the equals and hashCode implementations in CertificationData and InclusionProof to ensure consistency and reliability in hash-based collections.
MastaP
left a comment
MastaP
left a comment
There was a problem hiding this comment.
Three blocking equals/hashCode issues (inline) plus one cleanup item: src/main/java/org/unicitylabs/sdk/api/bft/verification/rule/InputRecordCurrentHashVerificationRule.java is left as a 0-byte file rather than removed. Please git rm it — its check is now folded into InclusionProofVerificationRule.verify (line 63), so the empty source file just adds confusion.
3 participants
No description provided.