You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think you can cfg individual fn off of a trait where that trait is implementable outside of the current crate. cfgs are supposed to be purely additive, and a codependency activating one of these cfgs could break an unrelated crate that built without the feature.
I don't think you can cfg individual fn off of a trait where that trait is implementable outside of the current crate.
Hmm, good point. We could make the trait private when the feature is disabled, and only provide the top-level functions, or we could make a breaking change and split it into two traits.
We could make the trait private when the feature is disabled, and only provide the top-level functions
I implemented this for now, as it is simple and backward-compatible.
This reduces the API for no_std crates to just default_caseless_match_str. We could expand on that in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two features, both enabled by default:
normalization- enables thecanonical_caseless_matchandcompatibility_caseless_matchmethods, which require theunicode_normalizationcrate.alloc- enables thedefault_case_fold_strconvenience method,which requires allocating a
String.Disabling both these features allows use of this crate for case folding in
no_stdprograms.