Open
Conversation
The generated files in this crate are produced from Unicode data files.
Author
|
Still unclear how to teach cargo about the licensing here. |
Manishearth
reviewed
Jun 15, 2022
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
| // Licensed under the Unicode license <LICENSE-UNICODE or https://www.unicode.org/license.txt>. |
Member
There was a problem hiding this comment.
this is autogenerated and the python file would also need to be updated
| @@ -1,5 +1,6 @@ | |||
| Licensed under the Apache License, Version 2.0 | |||
| <LICENSE-APACHE or | |||
| Licensed under the Unicode license <LICENSE-UNICODE or | |||
Member
There was a problem hiding this comment.
I would say that something like "code is licensed under ... , unicode data is licensed under ..."
Member
|
whoops wrong PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated files in this crate are produced from Unicode
data files.