Skip to content

target/tricore: Scale SRO LD.H offset by 2 #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandelayautollc wants to merge 2 commits into
base: dev
Choose a base branch
from
+23 −3
Open

target/tricore: Scale SRO LD.H offset by 2 #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84ca3ad
Scale SRO LD.H by 2
Jul 27, 2026
5854a01
Regression test for tricore sro ld.h
vandelayautollc Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qemu/target/tricore/translate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4169,7 +4169,7 @@ static void decode_sro_opc(DisasContext *ctx, int op1)
gen_offset_ld(ctx, tcg_ctx->cpu_gpr_d[15], tcg_ctx->cpu_gpr_a[r2], address, MO_UB);
break;
case OPC1_16_SRO_LD_H:
gen_offset_ld(ctx, tcg_ctx->cpu_gpr_d[15], tcg_ctx->cpu_gpr_a[r2], address, MO_LESW);
gen_offset_ld(ctx, tcg_ctx->cpu_gpr_d[15], tcg_ctx->cpu_gpr_a[r2], address * 2, MO_LESW);
break;
case OPC1_16_SRO_LD_W:
gen_offset_ld(ctx, tcg_ctx->cpu_gpr_d[15], tcg_ctx->cpu_gpr_a[r2], address * 4, MO_LESL);
Expand Down
24 changes: 22 additions & 2 deletions tests/unit/test_tricore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
#include "unicorn_test.h"

const uint64_t code_start = 0x1000;
const uint64_t code_start = 0x10000;
const uint64_t code_len = 0x4000;

TEST_LIST = {{NULL, NULL}};
static void test_sro_ld_h(void)
{
uc_engine *uc;
// ld.h d15, [a2]0x2 (SRO); EA = a2 + 2*off4 = code_start+4 -> 0x8123
char code[] = "\x8c\x22\x00\x00\x23\x81";
uint32_t d15, a2 = code_start;

OK(uc_open(UC_ARCH_TRICORE, UC_MODE_LITTLE_ENDIAN, &uc));
OK(uc_mem_map(uc, code_start, code_len, UC_PROT_ALL));
OK(uc_mem_write(uc, code_start, code, sizeof(code) - 1));
OK(uc_reg_write(uc, UC_TRICORE_REG_A2, &a2));

OK(uc_emu_start(uc, code_start, code_start + 2, 0, 0));

OK(uc_reg_read(uc, UC_TRICORE_REG_D15, &d15));
TEST_CHECK(d15 == 0xffff8123);

OK(uc_close(uc));
}

TEST_LIST = {{"test_sro_ld_h", test_sro_ld_h}, {NULL, NULL}};
Loading