add block hook with instruction count - #2378
Open
PhilippTakacs wants to merge 1 commit into
Open
Conversation
PhilippTakacs
added a commit
to PhilippTakacs/unicorn-engine-rs
that referenced
this pull request
Aug 6, 2026
PhilippTakacs
force-pushed
the
block_icount
branch
from
August 7, 2026 12:18
8f28e14 to
3331b0a
Compare
PhilippTakacs
marked this pull request as ready for review
August 7, 2026 12:19
Contributor
Author
|
@wtdcode it would be nice to have this in the next release. |
PhilippTakacs
force-pushed
the
block_icount
branch
from
August 7, 2026 12:38
3331b0a to
b00a5b9
Compare
wtdcode
reviewed
Aug 7, 2026
| } | ||
|
|
||
| if (type & UC_HOOK_CODE || type & UC_HOOK_BLOCK) { | ||
| if (type & UC_HOOK_BLOCK || type & UC_HOOK_BLOCK_ICOUNT) { |
Member
There was a problem hiding this comment.
Wait UC_HOOK_CODE is missing from this branch?
Contributor
Author
There was a problem hiding this comment.
This is to check if a UC_HOOK_BLOCK and a UC_HOOK_BLOCK_ICOUNT overlaps. I use this because this way the hook is simpler to implement, but doesn't allow a UC_HOOK_BLOCK and UC_HOOK_BLOCK_ICOUNT at the same tb. Overlapping with a UC_HOOK_CODE is not a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO disallow overlapping with block hook, write tests