Skip to content

docs: remove dead internal-tooling references #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unidoc-anom merged 1 commit into from
Jul 14, 2026
Merged

docs: remove dead internal-tooling references #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CODE_REVIEW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ Per Unix convention 2 is typically misuse, 1 is generic failure, >2 application-

- The `pdfservice` package is a thin proxy over `Inspector`. Consider whether you actually need the package boundary. `Inspector` itself could be the Wails service. Smaller surface area.
- The Go side does most of the heavy lifting; the React side has more state than it should (per-tab caches, navigation history, batch progress, palette state, find-bar state across hooks). Consider whether `useReducer` over a single store wouldn't be cleaner. The current sprawl makes test scaffolding heavy (1453-line `useDocumentState.test.tsx`).
- `_bmad-output` and `_bmad` symlinks into a sibling repo (`../docs`) make the build sensitive to repo layout; a CI clone with submodules or git-subtree would be more robust than a bare relative symlink.

## Top priorities

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ golangci-lint run ./...

Do NOT add new `strings.Contains`, `regexp.Match`, or other file-content assertions against `main.go`, `frontend/src/components/MainLayout.tsx`, or `frontend/src/components/EmptyState.tsx` from any test under `tests/`. If you find yourself reaching for that pattern, write a behavioural test (Vitest, Playwright, or `tests/boot-smoke`) instead.

Pre-existing structural greps in those files are grandfathered (see `docs/_bmad-output/implementation-artifacts/deferred-work.md` for the bulk-removal follow-up tracked under story 4-5). Do not extend the pattern. Reviewers must flag new source-greps at PR time.
Pre-existing structural greps in those files are grandfathered pending a bulk-removal follow-up. Do not extend the pattern. Reviewers must flag new source-greps at PR time.
Comment thread
gunnsth marked this conversation as resolved.

Generated build artifacts (`build/linux/*.desktop`, `build/darwin/Info.plist`, etc.) are exempt -- parsing those is legitimate behavioural testing on a build output, not source.

Expand Down
Loading