Bump Wails v3 to alpha2.117#5
Open
unidoc-anom wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the Wails v3 dependency and CI-installed wails3 CLI from v3.0.0-alpha2.103 to v3.0.0-alpha2.117, and adds a dedicated acceptance-test module to guard version-pin parity and the Go-JSON-to-frontend wire shape across future bumps.
Changes:
- Bump
github.com/wailsapp/wails/v3and align both CI workflows to installwails3@v3.0.0-alpha2.117. - Update root
go.mod/go.sumto reflect the new dependency graph after the bump. - Add a new independent Go test module (
tests/14-2-wails-alpha2-117-upgrade/) that asserts version pins, generated bindings presence/contract, and JSON key casing/value invariants via the built CLI.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates Wails v3 pin to v3.0.0-alpha2.117 and refreshes indirect requirements. |
go.sum |
Updates checksums for the bumped Wails version and tidy-related dependency changes. |
.github/workflows/ci.yml |
Bumps wails3 CLI install to v3.0.0-alpha2.117. |
.github/workflows/release.yml |
Bumps wails3 CLI install to v3.0.0-alpha2.117. |
tests/14-2-wails-alpha2-117-upgrade/go.mod |
Introduces an independent module for the story-specific acceptance/regression tests. |
tests/14-2-wails-alpha2-117-upgrade/helpers_test.go |
Shared helpers for repo-root discovery, file reads, version parsing, and building/running the CLI. |
tests/14-2-wails-alpha2-117-upgrade/version_pins_test.go |
Guards go.mod and workflow pin parity and runtime pin validity (no phantom alpha2 runtime). |
tests/14-2-wails-alpha2-117-upgrade/bindings_contract_test.go |
Ensures generated bindings still export the frontend-consumed method set. |
tests/14-2-wails-alpha2-117-upgrade/wire_shape_test.go |
Validates JSON key casing and selected value contracts from dump object --json. |
tests/14-2-wails-alpha2-117-upgrade/deferred_gates_test.go |
Documents non-automatable/manual gates as explicit skipped tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Wails v3 pin from alpha2.103 up to alpha2.117. The Go module and the
wails3CLI install lines in both CI workflows move together so the CLI and library stay on the same version.Regenerated the bindings with
wails3 generate bindings -clean=trueand the diff came back empty, so the Go/JS wire contract is unchanged. Left@wailsio/runtimeat alpha.79 since npm doesn't publish an alpha2 runtime and I didn't want to invent a version string that doesn't exist.Full gate is green locally:
go vet,golangci-lint,go test -race, the per-suite test loop,tsc, Vitest, ESLint, and a hostwails3 build. I also added a small test module that pins the go.mod and workflow versions and re-checks binding presence and wire shapes, so a later bump can't quietly move the wire contract without the tests catching it.Still open before merge: the manual desktop smoke on macOS and Windows. CI can't exercise the WebView, and Windows/WebView2 is where past bumps have broken, so I'd like it verified there before this goes in.