-
Notifications
You must be signed in to change notification settings - Fork 3
style: Reword to include network shield references #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,13 +94,13 @@ This lets you reference one instance's interface from another. | |
| When enabled, the guest configures the interface for you. | ||
| Disable it to leave the interface untouched, so your app or image can set up networking on its own. | ||
|
|
||
| ### Relay | ||
| ### Network Shield and Relay | ||
|
|
||
| The relay feature lets you redirect all network traffic from and to a network interface to another network interface. | ||
| In practice, this means you can set up a gateway or proxy VM and configure its network interface as the relay for another VM's network interface. | ||
|
|
||
| This is useful in sandbox environments - as a gateway or proxy can inspect, filter, and inject data into the sandbox's traffic. | ||
| In this setup, the sandbox doesn't need unfiltered network access or access to secrets. | ||
| The network shield feature provides the ability to transparently insert a “shield” between a microVM and the public Internet. | ||
| The shield provides filtering capabilities but also the possibility to inject credentials/secrets for agentic or other use cases. | ||
| This is useful in sandbox environments - as it means the sandbox will not need unfiltered network access or access to secrets. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [vale] reported by reviewdog 🐶 |
||
| The shield relies on a relay feature that redirects all network traffic to and from a network interface toward another network interface. | ||
| This allows for setting up a gateway/proxy VM and configure its interface as the relay for another VM's interface. | ||
|
|
||
| To use a relay, reference another interface by name inside a `relay` object: | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Microsoft.Headings] 'Network Shield and Relay' should use sentence-style capitalization.