feat(examples): Merged the two mariadb examples into one#253
Merged
Conversation
Signed-off-by: Dragos Gheorghioiu <dragosgheorghioiu9@gmail.com>
| To test the deployment, first forward the port with the `kraft cloud tunnel` command. | ||
|
|
||
| ```bash | ||
| kraft cloud tunnel 3306:mariadb-w2g2z:3306 |
Contributor
Author
There was a problem hiding this comment.
Should we replace tunnel with socat?
If I understood correctly, that would be the preferred approach going forward.
Or should I make that change in a future PR for all of the examples?
Contributor
There was a problem hiding this comment.
As agreed, we'll do this in a separate PR everywhere at once
nurof3n
approved these changes
Mar 30, 2026
nurof3n
left a comment
nurof3n
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
Approved-by: Alex-Andrei Cioc andrei.cioc@unikraft.io
craciunoiuc
approved these changes
Mar 30, 2026
craciunoiuc
left a comment
craciunoiuc
left a comment
Contributor
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged the two mariadb examples into a single one that also includes a volume section in the readme