Skip to content

fix(examples): Remove invalid characters from OCI image references#262

Closed
danielvallance wants to merge 1 commit into
unikraft-cloud:mainfrom
danielvallance:remove_plus_from_image_tag
Closed

fix(examples): Remove invalid characters from OCI image references#262
danielvallance wants to merge 1 commit into
unikraft-cloud:mainfrom
danielvallance:remove_plus_from_image_tag

Conversation

@danielvallance

Copy link
Copy Markdown
Contributor

Plus signs are not allowed, so I replaced them with 'p's

Resolves issue #261

@craciunoiuc craciunoiuc requested a review from nurof3n April 6, 2026 15:22
@nurof3n

nurof3n commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

@danielvallance rebase and I'll merge it, thanks!

@danielvallance danielvallance force-pushed the remove_plus_from_image_tag branch from 53fa3e6 to fb97fbc Compare April 6, 2026 16:23
@danielvallance

Copy link
Copy Markdown
Contributor Author

@nurof3n have rebased!

@danielvallance danielvallance marked this pull request as draft April 6, 2026 16:45
@danielvallance

Copy link
Copy Markdown
Contributor Author

Need to change some filenames in the .github/workflows, then should be good to go!

Plus signs are not allowed, so I replaced them with 'p's

Closes: unikraft-cloud#261
@danielvallance danielvallance force-pushed the remove_plus_from_image_tag branch from fb97fbc to 4eabb08 Compare April 7, 2026 08:11
@nurof3n

nurof3n commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@danielvallance the workflows are failing because the variables scope is from your fork. Could you reopen this as a branch instead of a fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants