Skip to content

chore: Remove unnecessary sleeps #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielvallance wants to merge 2 commits into from
Closed

chore: Remove unnecessary sleeps #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f7243
chore: Remove unnecessary sleeps
danielvallance Jul 5, 2026
5e29e10
chore: Use runner based in EU
danielvallance Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-examples.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ env:

jobs:
detect-changes:
runs-on: ubuntu-latest
runs-on: arc-ubuntu24.04-big
outputs:
matrix: ${{ steps.changes.outputs.matrix }}
steps:
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
needs: detect-changes
if: needs.detect-changes.outputs.matrix != ''
timeout-minutes: 60
runs-on: ubuntu-latest
runs-on: arc-ubuntu24.04-big

strategy:
fail-fast: false
Expand Down
2 changes: 0 additions & 2 deletions build-environments/test_build-environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def _cleanup_base():

# 1. Build the base image.
unikraft.build(context, base_tag)
time.sleep(3)

# 2. Run the base image; it auto-converts into a template.
unikraft.run_instance(
Expand All @@ -85,7 +84,6 @@ def _cleanup_base():
# 4. Build ROM images.
unikraft.build(context / "rom1", rom1_tag)
unikraft.build(context / "rom2", rom2_tag)
time.sleep(3)

return template_name, rom1_tag, rom2_tag

Expand Down
4 changes: 0 additions & 4 deletions conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,6 @@ def _build(example_dir: str, image_name: str) -> str:

unikraft.build(context, tag)

# TODO: drop this once the platform exposes a way to wait until a
# freshly-built image is fully available for `unikraft run`.
time.sleep(3)

return tag

return _build
Expand Down
1 change: 0 additions & 1 deletion minecraft/test_minecraft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def _cleanup_base():

# 1. Build the base image.
unikraft.build(context, base_tag)
time.sleep(3)

# 2. Run the base image with the base ROM; it auto-converts into a template.
unikraft.run_instance(
Expand Down
2 changes: 0 additions & 2 deletions node-code-execution/test_node-code-execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def _cleanup_base():

# 1. Build the base image.
unikraft.build(context, base_tag)
time.sleep(3)

# 2. Run the base image; it auto-converts into a template.
unikraft.run_instance(
Expand All @@ -85,7 +84,6 @@ def _cleanup_base():
# 4. Build ROM images.
unikraft.build(context / "rom1", rom1_tag)
unikraft.build(context / "rom2", rom2_tag)
time.sleep(3)

return template_name, rom1_tag, rom2_tag

Expand Down
Loading