ci: Add more unikraft run arguments to test wrapper#418
Merged
Conversation
This reduces reliance on using the extra_args catch-all, and will make later comparison between what the test runs and what is in the README easier Closes: FIELD-610
danielvallance
requested review from
ajpetersons,
craciunoiuc,
dragosgheorghioiu and
nurof3n
dragosgheorghioiu
approved these changes
Jul 6, 2026
dragosgheorghioiu
left a comment
dragosgheorghioiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Reviewed-by: Dragos Gheorghioiu dragosg@unikraft.com
Approved-by: Dragos Gheorghioiu dragosg@unikraft.com
| memory: str | None = None, | ||
| name: str | None = None, | ||
| metro: str | None = None, | ||
| scale_to_zero: str | Mapping[str, Any] | None = None, |
Contributor
There was a problem hiding this comment.
i think Mapping[str, str] could work here but is not needed
| metro: str | None = None, | ||
| scale_to_zero: str | Mapping[str, Any] | None = None, | ||
| template: str | None = None, | ||
| env: Sequence[str] | Mapping[str, Any] = (), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces reliance on using the extra_args catch-all, and will make later comparison between what the test runs and what is in the README easier
Closes: FIELD-610