chore(taskfile): Cleanup lint task#315
Open
robertgzr wants to merge 2 commits into
Open
Conversation
Determine the config path using a dynamic variable and then only run additional commands if we are creating the file from builtin configuration. This makes it so that for projects which ship their own config, only the actual linter invocation runs. Also sets the path-prefix option, to avoid suprises when the config is not located in the working directory. Golangci interprets paths passed to the output options as relative to config. Signed-off-by: Robert Günzler <robert@unikraft.cloud>
Member
|
Which projects do we want to actually ship their own config? Shouldn't we try and enforce a consistent style across all projects, instead of allowing customization? |
Contributor
Author
|
Agreed, it would be even better to enforce only the builtin config! |
Contributor
Author
|
@unikraft-cloud/team-tooling @unikraft-cloud/team-qa any objections to this? does anyone use a repo-local |
Contributor
Integration framework has a custom config, though it's not very indepth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine the config path using a dynamic variable and then only run
additional commands if we are creating the file from builtin
configuration.
This makes it so that for projects which ship their own config, only the
actual linter invocation runs.
Also sets the path-prefix option, to avoid suprises when the config is not
located in the working directory. Golangci interprets paths passed to the
output options as relative to config.
Signed-off-by: Robert Günzler robert@unikraft.cloud