added nasm#75
Open
sinamhdv wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks, @sinamhdv . Please format and sign off your commit according to Unikraft's contributor guidelines. Please also add a |
sinamhdv
force-pushed
the
add-nasm
branch
2 times, most recently
from
df44702 to
0afd0e6
Compare
razvand
requested changes
Sep 24, 2023
Contributor
|
@sinamhdv , also add a line mentioning how to check everything worked OK: |
Contributor
|
20 HP, 20 more when this is submitted |
sinamhdv
force-pushed
the
add-nasm
branch
2 times, most recently
from
4b7edeb to
30419ca
Compare
razvand
requested changes
Sep 24, 2023
added root directory, binary, and libraries for nasm to the dynamic-apps that can be run in bincompat mode. Signed-off-by: Sina Mahdavi <sinamhdv@gmail.com>
razvand
approved these changes
Sep 25, 2023
Contributor
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Please update the commit message to:
Add Nasm (Netwide Assembler)
Add Nasm root directory. It consists of the `nasm` binary, requried libraries and `README.md`. It is to be used with Unikraft in bincompat mode.
| ```console | ||
| objdump -D -b binary -m i386 -M intel,x86-64 sample_code | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Remove extra white line at the end.
| @@ -0,0 +1,43 @@ | |||
| # Netwide Assembler | |||
|
|
|||
| This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft. | |
| This is Nasm (_Netwide assembler_). | |
| it is meant to be used in the binary compatibility mode of Unikraft. |
| - `lib/` & `lib64/`: the required libraries for Nasm | ||
|
|
||
| ## Extract Dynamic Libraries | ||
|
|
Contributor
There was a problem hiding this comment.
Add wording. Say: "Use the extract.sh script to extract the required dynamic libraries for the binary:"
| ../extract.sh usr/bin/nasm | ||
| ``` | ||
|
|
||
| output: |
| ``` | ||
|
|
||
| ## Run on Linux | ||
|
|
| ``` | ||
|
|
||
| ## Run on Unikraft | ||
|
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.